Repository navigation
[bugfix] Fix slurm backend crash when polling job arrays - #3737
Merged
Merged
Conversation
The crash was happening inside _cancel_if_blocked() and it was due to two reasons: 1. The `squeue` commend used the wrong job id format 2. The job array jobids were treated verbatim instead of trimming the indexing part as it is done in other parts of the backend. This fix also applies for heterogeneous jobs. Signed-off-by: Vasileios Karakasis <vkarak@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3737 +/- ##
==========================================
- Coverage 91.89% 91.89% -0.01%
==========================================
Files 62 62
Lines 13802 13803 +1
==========================================
Hits 12684 12684
- Misses 1118 1119 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crash was happening inside _cancel_if_blocked() and it was due to two reasons:
squeuecommend used the wrong job id formatThis fix also applies for heterogeneous jobs.
Closes #3719.