WIP: Support auto-sheet selection with single sheet #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting the process, we want to be able to provide a secondary alternative route to the route lookup in template, so that we can skip to the next page should configuration allow it. This PR adds a 'sheetSelection' configuration property that can be set to 'manual' or 'automatic'. When set to automatic, and only a single sheet is found in the upload, the sheet selection step is skipped.
Unused function parameters (in some tests) result in a lint failure, which is a little extreme as now the function signature looks wrong for those tests.
rossjones
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting the process, we want to be able to provide a secondary alternative route to the route lookup in template, so that we can skip to the next page should configuration allow it.
This PR adds a 'sheetSelection' configuration property that can be set to 'manual' or 'automatic'. When set to automatic, and only a single sheet is found in the upload, the sheet selection step is skipped.
TODO
Resolves #197
Currently blocked wanting to test end-to-end as testing with playwright does not give us the option to mock a file on the server, and the prototype kit has the path to the config file hard-coded. Have added multi-project tests in the hope that we can start multiple copies of the server after replacing the app/config.json although this seems risky/flaky.