Licence compliance requirements for SheetJS fork #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating for tables
… to get defined tables Excel.js only offered an async API to load files, so we couldn't use it :'-( # Conflicts: # lib/importer/package.json # lib/importer/src/dudk/backend.js
rossjones
reviewed
Sep 2, 2025
rossjones
previously approved these changes
Sep 2, 2025
Contributor
rossjones
left a comment
rossjones
left a comment
There was a problem hiding this comment.
Looks good. I think we can ignore the CI failures for now and have a discussion on how to solve them in our local version of sheetjs. I'm happy to submit a separate PR for the tablecache cleanup if you're not sure about it.
…tion.js and sheet.js for selecting user defined tables.
…ets.js to select and preview tables.
rossjones
reviewed
Sep 5, 2025
Contributor
rossjones
left a comment
rossjones
left a comment
There was a problem hiding this comment.
Looks like a good approach but there are a couple of places where functions don't look like they're doing the right thing (badly cased map key, and empty return) - so it might be worth checking it is doing what you expect.
…elector and to extract the header row automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to import defiend tables, along with the associated SheetJS changes.