fix: compatibility issues with eslint v9 #158
Conversation
|
Hi @PHILLIPS71! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
| "trailingComma": "none", | ||
| "arrowParens": "avoid" | ||
| "arrowParens": "avoid", | ||
| "endOfLine": "auto" |
There was a problem hiding this comment.
Should probably be
"endOfLine": "lf"
so line endings get normalized to \n on format.
|
Thank you for this! I ended up fixing the errors on my branch. |
|
Thanks @net, I'll go ahead and close this PR. |
3 participants
I've forked #157 to help move it forward towards a release.
The main fix upgrades the ECMAScript version to 2020, which adds support for the nullish coalescing operator that was causing the original ESLint errors.