refactor!: rename docker-cmd-file to docker-entrypoint-file #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: input parameter `docker-cmd-file` is now `docker-entrypoint-file`
viceice
reviewed
Nov 18, 2024
| Only applicable when 'mount-docker-socket' is true. | ||
| required: false | ||
| default: /var/run/docker.sock | ||
| docker-cmd-file: |
Member
There was a problem hiding this comment.
please add docker-cmd-file as deprecated input for now but don't document in readme. So we're backward compatible
viceice
reviewed
Nov 28, 2024
| The Renovate Docker image name to use. | ||
| If omitted or `renovate-image === ''` the action will use the `ghcr.io/renovatebot/renovate` Docker image name otherwise. | ||
| If a Docker image name is defined, the action will use that name to pull the image. | ||
| Note: Use only the image name without a tag, [`renovate-version`](#renovate-version) is used as the image tag. |
Member
There was a problem hiding this comment.
unrelated, please open a separate PR
| description: | | ||
| Override the environment variables which will be passsed into the renovate container. | ||
| Defaults to `^(?:RENOVATE_\\w+|LOG_LEVEL|GITHUB_COM_TOKEN|NODE_OPTIONS|(?:HTTPS?|NO)_PROXY|(?:https?|no)_proxy)$` | ||
| Defaults to `^(?:RENOVATE_\w+|LOG_LEVEL|GITHUB_COM_TOKEN|NODE_OPTIONS|(?:HTTPS?|NO)_PROXY|(?:https?|no)_proxy)$` |
Comment on lines
+81
to
+85
| const cmdFile = core.getInput('docker-entrypoint-file'); | ||
| const entryPointFile = | ||
| !!cmdFile && cmdFile !== '' | ||
| ? cmdFile | ||
| : core.getInput('docker-entrypoint-file'); |
Comment on lines
+87
to
+89
| return !!entryPointFile && entryPointFile !== '' | ||
| ? path.resolve(entryPointFile) | ||
| : null; |
Member
There was a problem hiding this comment.
Suggested change
| return !!entryPointFile && entryPointFile !== '' | |
| ? path.resolve(entryPointFile) | |
| : null; | |
| return entryPointFile | |
| ? path.resolve(entryPointFile) | |
| : null; |
simplify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address the comment #817 (comment)
This is a breaking change and requires a major release.
I am open to changing it to non-breaking change if maintainers wish so.