Skip to content

Conversation

@ignaciosantise
Copy link
Collaborator

This pull request updates the Android and iOS release workflows to improve build traceability, add S3 upload support, and introduce a new required project-type parameter. The workflows now differentiate between wallet and dapp projects, include branch information in release notes and artifact names, and upload release artifacts to AWS S3 for both platforms. Additionally, caching strategies have been enhanced to be branch-aware, and AWS credentials are now configured within the workflows.

Workflow enhancements and new parameters:

  • Added a required project-type input (wallet/dapp) to all release workflows and propagated its use throughout job definitions and Fastlane scripts to distinguish between project types. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Artifact upload and AWS integration:

  • Integrated AWS S3 uploads for both Android and iOS builds, including configuration of AWS credentials and use of a new required aws-account-id input. Artifacts are named and stored by project type and release type. [1] [2] [3] [4]

Release note and artifact naming improvements:

  • Enhanced release notes and artifact names to include project-type, release-type, and the branch name for better traceability in both Firebase distribution and TestFlight uploads. [1] [2]

Caching improvements:

  • Updated Gradle and CocoaPods cache keys to include the branch name, improving cache accuracy and isolation between branches. Also upgraded cache actions to v4. [1] [2]

Permissions updates:

  • Added id-token: write permission to workflows to support secure authentication for AWS credential configuration. [1] [2]

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the Android and iOS release workflows by adding build artifact traceability, AWS S3 upload capabilities, and project-type differentiation. The changes improve the CI/CD pipeline with better build management and storage.

  • Introduced a required project-type parameter to distinguish between wallet and dapp projects
  • Added AWS S3 upload functionality for build artifacts with proper credential configuration
  • Enhanced release notes and artifact naming to include branch information and project type for better traceability

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/release-android-base.yaml Added project-type parameter, AWS credentials, S3 upload, and enhanced Firebase release notes
.github/workflows/release-ios-base.yaml Added project-type parameter, AWS credentials, S3 upload, and improved caching with branch awareness
fastlane/Fastfile Updated iOS build output naming and TestFlight changelog to include project type and branch
Release workflow files Added project-type parameter to all wallet and dapp workflow configurations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ignaciosantise ignaciosantise marked this pull request as ready for review October 16, 2025 12:50
@ignaciosantise ignaciosantise merged commit a56ab82 into main Oct 21, 2025
5 of 8 checks passed
@ignaciosantise ignaciosantise deleted the chore/bucket branch October 21, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants