Adam/envelope attribution - #36
Merged
Merged
Conversation
…er_id BREAKING CHANGE: DocumentEventCallback now takes three new parameters (user_id, author_name, visibility) inserted before context, in that exact order. This is a sanctioned C ABI break; the only current consumer (entonal-common's TonalDB) will be updated in a later task. - events.rs: extend DocumentEventCallback typedef; thread user_id/ author_name/visibility from Document through QueuedEvent and the event-dispatch marshaling (CString allocation, null when absent, mirroring the existing title/content convention). Add emit_document_created_with_attribution/emit_document_updated_with_attribution. - ffi.rs: update all document-event emission call sites to pass attribution from the Document; add replicant_get_user_id (char** out + SyncResult convention, paired with existing replicant_string_free). - client.rs: update emit_document_created/emit_document_updated call sites to use the new attribution-carrying variants. - dist/include/replicant.h regenerated via cbindgen (build.rs + scripts/build_dist.py) — not hand-edited. - replicant-client/include/replicant.hpp: hand-edit adds std::string get_user_id() wrapping replicant_get_user_id, matching the get_document()/get_version() error-handling idiom. - tests/ffi_integration_tests.rs: extend the callback signature and DocumentCapture to the new 8-parameter arity; assert user_id arrives non-null and round-trips against replicant_get_user_id. Claude-Session: https://claude.ai/code/session_014v9ckeoEb1eNH3K2t6fdH5
… the 8-arg callback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.