feat: initial implementation of terraform for aws (self hosted)#187
feat: initial implementation of terraform for aws (self hosted)#187marccampbell wants to merge 3 commits intomainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
scottrigby
left a comment
scottrigby
left a comment
There was a problem hiding this comment.
Rubber stamping the Terraform (the main purpose of this PR) 👍 can set up auto testing later and any fixes can be additional PRs as needed.
Also the massive gofmt whitespace and newline cleanup looks good. Had to happen sometime 😅
Note that early design docs and files like CLAUDE.md are also deleted in this PR. These seem unrelated to this PR, but fine to remove. CLAUDE.md wasn't very useful in it's current state anyway. Files like design/convert-k8s-to-helm/README.md did seem potentially useful to explain what's going on. But we might want to look at #97 to better explain the request lifecycle (if I'm right about how these workflows work in that PR).
LGTM
| // Send error to the error channel and exit | ||
| select { | ||
| case errCh <- fmt.Errorf(errMsg): | ||
| case errCh <- fmt.Errorf("No activity from LLM for 2 minutes, operation stalled (last activity at %s)", lastActivity.Format(time.RFC3339)): |
There was a problem hiding this comment.
nit: exact copy of string passed to fmt.Sprintf in errMsg, could be refactored to a var reused there and here. not critical.
| docs: | ||
| reference: | |
There was a problem hiding this comment.
wasn't sure if reference works, since the only example I saw in code was install. but looks like we allow any map key https://github.com/replicatedhq/kotskinds/blob/main/apis/kots/v1beta2/helmchart_types.go#L405. Assuming this is fine.
PS we should also update the reference page at https://docs.replicated.com/reference/custom-resource-helmchart-v2 to include docs, per replicatedhq/kotskinds#57.
| apiVersion: kots.io/v1beta1 | ||
| kind: Terraform |
There was a problem hiding this comment.
scottrigby
changed the title
|
Converting PR to Draft because Marc said this is still in progress. |
2 participants
also runs go fmt ./... on the code