[#1061] Remove unused dependency#1095
Merged
Merged
Conversation
Draft
Contributor
Author
Tejas2805
changed the title
Member
|
Is there more dependency to remove? |
Contributor
Author
|
This is the only dependency that we can remove. There might be other optimizations in Gradle possible though |
Contributor
Author
|
@fzdy1914 Have checked for other Gradle lint rules. All seem to be okay. |
Member
|
OK |
fzdy1914
approved these changes
Feb 26, 2020
eugenepeh
approved these changes
Feb 27, 2020
jamessspanggg
approved these changes
Feb 28, 2020
Contributor
|
I just have a question to better understand the gradle build file. Do we know how this dependency was being used in the past? Or was it always unused? |
Contributor
|
Based on a search, it seems that this Java Parser library was previously used in the |
anubh-v
approved these changes
Feb 29, 2020
Tejas2805
added a commit
to Tejas2805/RepoSense
that referenced
this pull request
Mar 6, 2020
* 'master' of https://github.com/reposense/RepoSense: [reposense#1047] v_summary: simplify toDisplay user logic (reposense#1051) [reposense#658] Modify checkstyle configuration (reposense#1094) Add commit message length configuration border (reposense#1048) [reposense#1061] build.gradle: remove unused dependency (reposense#1095) [reposense#1044] Update date hashes on reset date range (reposense#1068)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #1061