Repository navigation
fix(risk): say when line coverage is stored without a per-test map, and flag stale measured tests - #4339
Merged
Conversation
|
🔍 1 thing to check
➖ Health of changed files: 8.30 → 8.29 (-0.01; structure -0.02)
🧾 Evidence: 1 to look at, 6 not known
AI review is paused: this repository reached its monthly spending limit. Bot settings 📊 See the full report for this PR Settings and updatesUpdated 2026-10-21 08:57 UTC |
RaghavChamadiya
force-pushed
the
fix/tests-tab-one-reach
branch
from
October 20, 2026 22:52
45baed2 to
df51363
Compare
RaghavChamadiya
force-pushed
the
fix/get-risk-coverage-honesty
branch
from
October 20, 2026 22:52
d482c5d to
629c672
Compare
RaghavChamadiya
force-pushed
the
fix/tests-tab-one-reach
branch
from
October 21, 2026 04:36
df51363 to
6b716d6
Compare
RaghavChamadiya
force-pushed
the
fix/get-risk-coverage-honesty
branch
2 times, most recently
from
October 21, 2026 04:49
2211f50 to
7dcedf5
Compare
RaghavChamadiya
force-pushed
the
fix/tests-tab-one-reach
branch
from
October 21, 2026 04:49
6b716d6 to
038ffa9
Compare
RaghavChamadiya
force-pushed
the
fix/get-risk-coverage-honesty
branch
from
October 21, 2026 05:37
7dcedf5 to
f2f79c6
Compare
RaghavChamadiya
force-pushed
the
fix/tests-tab-one-reach
branch
2 times, most recently
from
October 21, 2026 05:40
d4147fc to
7db4673
Compare
RaghavChamadiya
force-pushed
the
fix/get-risk-coverage-honesty
branch
from
October 21, 2026 05:40
f2f79c6 to
241bbea
Compare
RaghavChamadiya
force-pushed
the
fix/tests-tab-one-reach
branch
from
October 21, 2026 07:26
7db4673 to
d2ef818
Compare
RaghavChamadiya
force-pushed
the
fix/get-risk-coverage-honesty
branch
from
October 21, 2026 07:26
241bbea to
95d5636
Compare
RaghavChamadiya
force-pushed
the
fix/tests-tab-one-reach
branch
from
October 21, 2026 07:33
d2ef818 to
aef9870
Compare
RaghavChamadiya
force-pushed
the
fix/get-risk-coverage-honesty
branch
from
October 21, 2026 07:33
95d5636 to
56163eb
Compare
…nd flag stale measured tests get_risk read "coverage unavailable" and "test gaps withheld" on a repository with stored line coverage, because only the per-test map counted. The test impact now names that case (no_per_test_map_aggregate_available, with the stored file count and freshness). Measured recommendations say they match a changed file rather than its lines, and a measured-only row whose test file git shows deleted or edited since the measured commit carries stale and stale_reason.
RaghavChamadiya
force-pushed
the
fix/get-risk-coverage-honesty
branch
from
October 21, 2026 08:56
56163eb to
26d1fd2
Compare
swati510
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a repository with stored line coverage but no per-test map,
get_risksaid coverage was unavailable and test gaps were withheld.get_risksays no per-test map exists and that aggregate line coverage is available (coverage.reason: no_per_test_map_aggregate_available). It givescoverage.aggregatewith the file count, measured commit and freshness.evidence[].match: "file"), sinceget_riskonly receives paths.stale: trueand astale_reason. A row the graph also backs is never marked stale.Stacked on #4334.
On this repository:
coverage.aggregate = {file_count: 2223, ingested_commit: 7c3fbfe…, freshness: stale}with the new reason, where before it said "coverage unavailable".Verification
tests/unit/{analysis,persistence,server}: 11,542 passed.tsc --noEmitclean in types, ui and web;ruff checkclean.