Repository navigation
fix(core): classify module.test-utils files as test support - #4353
Merged
RaghavChamadiya merged 1 commit intoOct 24, 2026
Conversation
ShryukGrandhi
requested review from
RaghavChamadiya and
swati510
as code owners
October 21, 2026 14:45
RaghavChamadiya
approved these changes
Oct 24, 2026
RaghavChamadiya
left a comment
Member
There was a problem hiding this comment.
Requiring the dot that ties test-utils to a module keeps a bare test-utils.js counted as production. Thanks @ShryukGrandhi, and welcome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/foo.test-utils.ts(and the.js/.mjsforms) is now classified as test support. Before this change it was scored as production code.utilscounts as a scaffolding word only when a dot ties the name to a module (<module>.test-utils.*). Baretest-utils.js, which React and Preact publish as a package entry, is still production code.src/test-supporter.tsas a negative row.On current main,
foo.test-support.tsandfoo.test-helpers.tswere already classified as support by_is_support_compound. Onlyfoo.test-utils.tswas still unclassified, becauseutilsis deliberately left out of_SUPPORT_NAME_WORDS. I kept these names out oftest_infixes, so they are support and not tests. That matches how.test-harness.and.test-setup.are handled today.Related Issues
Fixes #3269
Test Plan
pytest):uv run pytest tests/unit/test_test_paths.py(the newfoo.test-utilsrows fail before the change and pass after it), plus every unit test module that references the test-path classifier (1725 passed)ruff check .) on the touched filesChecklist