Repository navigation
VS Code: report Command.GoToStepDefinition for F12 / Ctrl+Click - #1308
Merged
Merged
Conversation
textDocument/definition also fires on hover, so a response is remembered and counted as a navigation only when the active editor lands on a returned location within two seconds. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1266 (option 1: client-side detection).
textDocument/definitionalso fires on Ctrl+hover, so the request alone cannot say a navigation happened. AprovideDefinitionmiddleware records each response's targets;Command.GoToStepDefinition(withLocationCount) is sent only when the active editor or selection then lands on one of those targets within 2s. A hover never moves the editor, so it sends nothing.Logic lives in
lsp/definitionNavigation.ts(pureDefinitionNavigationTrackerwith an injectable clock, plus the middleware and editor-event registration).Testing
definitionNavigationsuite (tracker + result mapping) passes in the extension host.defineStepRecovery,Language client should start after activation) that need a built server/fixture and are unrelated to this change.Not verified
🤖 Generated with Claude Code