Skip to content

feat/improve navbar menu #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodeKei02 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat/improve navbar menu #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3b6465
Feat:(ui) add custom hook useScrolled to track page scroll position
CodeKei02 Jul 13, 2026
9d80a30
refactor(header): utilize useScrolled hook for dynamic styling based …
CodeKei02 Jul 13, 2026
04f5b9a
refactor(home): move Header component outside of Hero for improved la…
CodeKei02 Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 57 additions & 34 deletions src/components/Header.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { Logo } from '@/components/Logo';
import { NavLink } from '@/components/NavLink';
import { Icon, InlineIcon } from '@iconify/react';
import { StarButton } from './StarButton';
import { useScrolled } from '@/hooks/useScrolled';

function MobileNavLink({ href, children }) {
return (
Expand Down Expand Up @@ -43,7 +44,7 @@ function MobileNavigation() {
return (
<Popover>
<Popover.Button
className="relative z-10 flex h-8 w-8 items-center justify-center [&:not(:focus-visible)]:focus:outline-none"
className="relative z-20 flex h-8 w-8 items-center justify-center [&:not(:focus-visible)]:focus:outline-none"
aria-label="Toggle Navigation"
>
{({ open }) => <MobileNavIcon open={open} />}
Expand All @@ -58,7 +59,7 @@ function MobileNavigation() {
leaveFrom="opacity-100"
leaveTo="opacity-0"
>
<Popover.Overlay className="fixed inset-0 bg-slate-300/50" />
<Popover.Overlay className="fixed inset-0 z-10 bg-slate-300/50" />
</Transition.Child>
<Transition.Child
as={Fragment}
Expand All @@ -71,7 +72,7 @@ function MobileNavigation() {
>
<Popover.Panel
as="div"
className="absolute inset-x-0 top-full mt-4 flex origin-top flex-col rounded-2xl bg-white p-4 text-lg tracking-tight text-slate-900 shadow-xl ring-1 ring-slate-900/5"
className="absolute inset-x-0 top-full z-30 mt-4 flex origin-top flex-col rounded-2xl bg-white p-4 text-lg tracking-tight text-slate-900 shadow-xl ring-1 ring-slate-900/5"
>
<MobileNavLink href="/#features">Features</MobileNavLink>
<MobileNavLink href="/#testimonials">Testimonials</MobileNavLink>
Expand All @@ -86,39 +87,61 @@ function MobileNavigation() {
}

export function Header() {
const scrolled = useScrolled();

return (
<header className="py-10">
<Container>
<nav className="relative z-50 flex justify-between">
<div className="flex items-center md:gap-x-12">
<Link href="/" aria-label="Home">
<Logo className="h-16 w-auto" />
</Link>
<div className="hidden md:flex md:gap-x-6">
<NavLink href="/#features">Features</NavLink>
<NavLink href="/#testimonials" className="md:hidden lg:inline-block">
Testimonials
</NavLink>
<NavLink href="/sponsor">Sponsor</NavLink>
<NavLink href="/blog">Blog</NavLink>
<NavLink href="/join-discord" className="md:hidden lg:inline-block">
Join Discord
</NavLink>
<>
<header
className={clsx(
'fixed inset-x-0 top-0 z-50 transition-all duration-300',
scrolled ? 'py-2 sm:py-3' : 'py-4 sm:py-6'
)}
>
<div
aria-hidden="true"
className={clsx(
'absolute inset-0 -z-10 bg-white/85 shadow-sm ring-1 ring-slate-900/5 backdrop-blur-md backdrop-saturate-150 transition-opacity duration-300 supports-[backdrop-filter]:bg-white/60',
scrolled ? 'opacity-100' : 'opacity-0'
)}
/>
<Container>
<nav className="relative flex items-center justify-between">
<div className="flex items-center md:gap-x-12">
<Link href="/" aria-label="Home">
<Logo
className={clsx(
'w-auto transition-all duration-300',
scrolled ? 'h-10 sm:h-12' : 'h-12 sm:h-16'
)}
/>
</Link>
<div className="hidden md:flex md:gap-x-6">
<NavLink href="/#features">Features</NavLink>
<NavLink href="/#testimonials" className="md:hidden lg:inline-block">
Testimonials
</NavLink>
<NavLink href="/sponsor">Sponsor</NavLink>
<NavLink href="/blog">Blog</NavLink>
<NavLink href="/join-discord" className="md:hidden lg:inline-block">
Join Discord
</NavLink>
</div>
</div>
</div>
<div className="flex items-center gap-x-5 md:gap-x-8">
<StarButton />
<Button href="/download" color="green">
<span>
Download <span className="hidden lg:inline">Now</span>
</span>
</Button>
<div className="-mr-1 md:hidden">
<MobileNavigation />
<div className="flex items-center gap-x-5 md:gap-x-8">
<StarButton />
<Button href="/download" color="green">
<span>
Download <span className="hidden lg:inline">Now</span>
</span>
</Button>
<div className="-mr-1 md:hidden">
<MobileNavigation />
</div>
</div>
</div>
</nav>
</Container>
</header>
</nav>
</Container>
</header>
<div aria-hidden="true" className="h-20 sm:h-28" />
</>
);
}
14 changes: 14 additions & 0 deletions src/hooks/useScrolled.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { useEffect, useState } from 'react';

export function useScrolled(threshold: number = 8): boolean {
const [scrolled, setScrolled] = useState(false);

useEffect(() => {
const onScroll = () => setScrolled(window.scrollY > threshold);
onScroll();
window.addEventListener('scroll', onScroll, { passive: true });
return () => window.removeEventListener('scroll', onScroll);
}, [threshold]);

return scrolled;
}
2 changes: 1 addition & 1 deletion src/pages/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ export default function Home() {
</Head>

<main className="relative">
<Header />
<div className="relative">
<div className="relative z-10">
<Header />
<Hero />
</div>
</div>
Expand Down