Skip to content

Avoid propagating ApplySet labels to owned resources - #171

Open
BjarkeTornager wants to merge 1 commit into
restatedev:mainfrom
BjarkeTornager:fix/do-not-propagate-applyset-label
Open

Avoid propagating ApplySet labels to owned resources#171
BjarkeTornager wants to merge 1 commit into
restatedev:mainfrom
BjarkeTornager:fix/do-not-propagate-applyset-label

Conversation

@BjarkeTornager

Copy link
Copy Markdown

Summary

  • exclude labels in the applyset.kubernetes.io/ namespace when propagating RestateDeployment labels
  • apply the filter to versioned Services and Knative Configurations/Routes
  • retain all ordinary user labels
  • document the behavior change

Why

kubectl adds applyset.kubernetes.io/part-of to resources applied with --applyset. Copying it to an operator-owned versioned Service makes that Service look like a direct ApplySet member. When the same ApplySet contains the Service kind, a later prune can delete the versioned Service before Restate has drained that deployment.

Because the children are server-side applied by the operator, a reconciliation after upgrade also removes labels that older operator versions propagated.

Validation

  • cargo fmt --check
  • cargo test --lib (83 passed)
  • cargo clippy --all-targets --all-features -- -D warnings

cargo test also runs five existing doctests that fail on current main; all 83 unit tests pass.

Closes #170.

@github-actions

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RestateDeployment propagates ApplySet membership to owned resources

1 participant