Avoid propagating ApplySet labels to owned resources - #171
Open
BjarkeTornager wants to merge 1 commit into
Open
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applyset.kubernetes.io/namespace when propagatingRestateDeploymentlabelsWhy
kubectl adds
applyset.kubernetes.io/part-ofto resources applied with--applyset. Copying it to an operator-owned versioned Service makes that Service look like a direct ApplySet member. When the same ApplySet contains the Service kind, a later prune can delete the versioned Service before Restate has drained that deployment.Because the children are server-side applied by the operator, a reconciliation after upgrade also removes labels that older operator versions propagated.
Validation
cargo fmt --checkcargo test --lib(83 passed)cargo clippy --all-targets --all-features -- -D warningscargo testalso runs five existing doctests that fail on currentmain; all 83 unit tests pass.Closes #170.