Skip to content

fix: handle async unselect #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ni55aN merged 2 commits into from
Sep 1, 2025
Merged

fix: handle async unselect #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0d2550
fix: handle async unselect
Ni55aN Jun 6, 2025
ef91306
build: update rete-area-plugin version to 2.1.4 in dependencies
Ni55aN Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@
},
"peerDependencies": {
"rete": "^2.0.1",
"rete-area-plugin": "^2.0.0"
"rete-area-plugin": "^2.1.4"
},
"devDependencies": {
"globals": "^15.9.0",
"rete": "^2.0.1",
"rete-area-plugin": "^2.0.0",
"rete-area-plugin": "^2.1.4",
"rete-cli": "~2.0.1",
"rollup-plugin-sass": "1.12.17",
"typescript": "4.8.4"
Expand Down
8 changes: 4 additions & 4 deletions src/extensions/selectable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
* @param selector Selector instance
* @param accumulating Accumulating state
*/
export function selectable<S extends ExpectedSchemes, K>(plugin: CommentPlugin<S, K>, selector: Selector, accumulating: { active(): boolean }) {

Check warning on line 13 in src/extensions/selectable.ts

View workflow job for this annotation

GitHub Actions / ci / ci 

This line has a length of 144. Maximum allowed is 120

Check warning on line 13 in src/extensions/selectable.ts

View workflow job for this annotation

GitHub Actions / ci / ci 

This line has a length of 144. Maximum allowed is 120
// eslint-disable-next-line max-statements, complexity
plugin.addPipe(context => {
plugin.addPipe(async context => {
if (!context || typeof context !== 'object' || !('type' in context)) return context

if (context.type === 'commentlinktranslate') {
Expand All @@ -24,8 +24,8 @@
const comment = context.data
const { id } = comment

if (!accumulating.active()) selector.unselectAll()
selector.add({
if (!accumulating.active()) await selector.unselectAll()
await selector.add({
id,
label: 'comment',
translate(dx, dy) {
Expand All @@ -41,7 +41,7 @@
if (context.type === 'commentunselected') {
const { id } = context.data

selector.remove({ id, label: 'comment' })
await selector.remove({ id, label: 'comment' })
}
if (context.type === 'commenttranslated') {
const { id, dx, dy } = context.data
Expand Down
Loading