Skip to content

Fix ebnf terminals#39

Open
Zverik wants to merge 2 commits into
rezemika:masterfrom
Zverik:master
Open

Fix ebnf terminals#39
Zverik wants to merge 2 commits into
rezemika:masterfrom
Zverik:master

Conversation

@Zverik

@Zverik Zverik commented Jan 5, 2021

Copy link
Copy Markdown

They didn't work before, and since a recent version of parser they produce exceptions.

@rezemika

rezemika commented Jan 5, 2021

Copy link
Copy Markdown
Owner

Thank you for your contribution! However, this repo is currently unmaintained (because the opening_hours field is so difficult to parse properly), so I probably won't merge it for now. I hope I'll be able to rewrite it cleanly one day...

@Zverik

Zverik commented Jan 5, 2021

Copy link
Copy Markdown
Author

Thanks for the reply Michael! Yeah, I know it's on hold. But still, this is the best library for parsing the hours, and I'm using it in my mapping project. Let this PR sit here please, for somebody might encounter the same issue I did. I'm okay with not merging it.

@rezemika

rezemika commented Jan 6, 2021

Copy link
Copy Markdown
Owner

Oh thanks! So bad this field is so complicated, to write a simpler parser would mean giving up the parse of the most complex fields, so I don't know what to do... Does your version pass all the unit tests? If so I'm okay with merging it. :)

@Stemby

Stemby commented Nov 30, 2021

Copy link
Copy Markdown

This PR fixes issue #34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants