fix 2.1.14 parsing by including an extra unknown field - #7
Conversation
|
I think unit group might not be the correct change. |
|
Yeah, i'm pretty lost in this unit group stuff. I determined where to put this new line of code by stepping through with a debugger until something parsed clearly wrong, like a float parsing as If there's a better approach than guesswork, we should definitely be able to do better than this PR. |
|
Yeah, I'm guessing it broke in unit group because that new field is part of enemy expansion which happens right before unit group and the first couple fields of unit group are the same type as the last few fields of enemy expansion. Short of decompiling the factorio binary, I think guesswork with hints from the doc changes is our best option. If you want to make the change in this PR I'll merge it. If you'd prefer to close this PR and open a new one I can merge that. Or I can just make the change. Whatever is easier for you with your other PR is good with me. |
|
Looks like that field was added to the data repo in their latest commit. wube/factorio-data@8c37187#diff-d63ed68af1a2bdf627a00071fe54cf544ff575339461af0cd9bef43580c242bc |
|
I added v2.1.13 support in 9c5bd61 by adding |
closes #6.
This makes a default settings exchange string parse without errors for Factorio 2.1.14.
I didn't find any explanation of this field in https://lua-api.factorio.com/latest/types/UnitGroupSettings.html , so i called it
unknown.