Added ML-DSA-87 verification - #827
Open
nfrayer wants to merge 2 commits into
Open
Conversation
nfrayer
commented
Aug 24, 2026
nfrayer
commented
Contributor
- Enabled SHA3 in the configuration header for SHAKE-128/SHAKE-256
- Modified Pkcs7Verify() to add a code path for ML-DSA-87
ML-DSA-87 internally requires SHAKE-128 and SHAKE-256 for its cryptographic operations. Removing OPENSSL_NO_SHA3 from the configuration header to enable it. Signed-off-By: Nicolas Frayer <nfrayer@redhat.com>
ML-DSA-87 doesn't follow OpenSSL's internal PKCS7_signatureVerify three-step digest pipeline as RSA does. So adding a specific verification path for it. Signed-off-by: Nicolas Frayer <nfrayer@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #827 +/- ##
==========================================
- Coverage 59.48% 58.77% -0.71%
==========================================
Files 24 24
Lines 4226 4226
Branches 655 654 -1
==========================================
- Hits 2514 2484 -30
Misses 1471 1471
- Partials 241 271 +30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vathpela
requested changes
Aug 24, 2026
| Pkey = X509_get0_pubkey (sk_X509_value (Signers, 0)); | ||
| } | ||
|
|
||
| if (Pkey != NULL && EVP_PKEY_is_a (Pkey, "ML-DSA-87")) { |
Member
There was a problem hiding this comment.
Is there a reason we're specifically checking for 87 here? It seems like all ML-DSA should go through this path, and any size should work so long as they're the same in VerifyMlDsaPkcs7Signature()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.