chore(ci): repair installs and streamline workflow gates - #1075
Merged
Conversation
The lock file was out of sync with package.json, so `npm ci` aborted on every workflow before any check ran. Regenerate package-lock.json (npm 10, matching CI) so it satisfies package.json under both strict and legacy peer resolution. Also rationalize the CI surface, which had grown redundant and flaky: - Remove syntax.yml (its type-check and ESLint duplicate the CI workflow). - Remove test.yml (its tests duplicate the CI workflow and it pinned an inconsistent Node 18). - Take performance-regression.yml off PRs (startup time, k6 API latency and bundle regression need baselines and a reachable API); run it on a schedule and on demand instead. - Make bundle-size tracking non-blocking (informational reporting). - Rename appInit.test.ts to .tsx so its JSX parses under tsc. The remaining required PR gates are CI (lint/type/test/build), Dependency Audit, Dependency boundaries and Native Build.
This was referenced Sep 8, 2026
Contributor
Author
|
Verified in CI: with the re-synced lock file, installs now succeed on every workflow (jobs run their real steps instead of aborting at
This PR intentionally scopes to restoring installs and trimming the redundant/flaky workflow surface; the debt above is left for separate, focused work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs mobile CI installs and rationalizes an over-grown, partly-flaky workflow set.
Why
Every workflow installs with
npm ci, which was aborting before any check ran becausepackage-lock.jsonwas out of sync withpackage.json(dependency-cruiser,license-checkerand their transitive deps were missing). With installs unblocked, the CI surface also turned out to be redundant and flaky.What changed
package-lock.jsonwith npm 10 (matching CI) so it satisfiespackage.jsonunder both strict and--legacy-peer-depsresolution. Verifiednpm cisucceeds locally.syntax.yml— its type-check + ESLint duplicate the CI workflow.test.yml— its tests duplicate the CI workflow, and it pinned an inconsistent Node 18.performance-regression.ymloff PRs — startup time, k6 API latency and bundle-regression gates depend on baselines and a reachable API; now scheduled +workflow_dispatch.bundle-size.ymlnon-blocking — informational reporting only (continue-on-error).appInit.test.ts→.tsxso its JSX parses undertsc.Remaining required PR gates: CI (lint/type/test/build), Dependency Audit, Dependency boundaries, Native Build.
Known limitation (tracked separately)
The CI workflow's
Typecheckstep will still fail:tsc --noEmitreports ~499 pre-existing errors across 264 files that predate this change and require a codebase-wide cleanup. That debt is tracked in #1074. This PR deliberately does not attempt it — it restores installs and trims the workflow set so that future work has a sane, non-flaky CI surface to build on.closes #1072