Skip to content

Conversation

@shanicky
Copy link
Contributor

@shanicky shanicky commented Nov 7, 2025

Replace the previous warning log and permissive behavior with a panic when encountering an unexpected mutation type at startup.

  • Enforce strict correctness by failing fast on protocol violations
  • Prevent subtle bugs caused by silently ignored invalid mutations
  • Improve observability and debugging of startup barrier processing
  • Harden the streaming executor initialization logic against invalid input

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

Replace the previous warning log and permissive behavior with a panic
when encountering an unexpected mutation type at startup.

- Enforce strict correctness by failing fast on protocol violations
- Prevent subtle bugs caused by silently ignored invalid mutations
- Improve observability and debugging of startup barrier processing
- Harden the streaming executor initialization logic against invalid input

Signed-off-by: Peng Chen <[email protected]>
Signed-off-by: Peng Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants