Skip to content

Conversation

@BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Design RFC: Notion

Note that an extra keyword CONFIG is introduced and used because plain SET and RESET should be used to alter the entries from WITH (..), according to the convention of Postgres syntax. Although we've decided to use ALTER CONNECTOR WITH for this instead.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@graphite-app
Copy link

graphite-app bot commented Nov 11, 2025

Looks like this PR extends new SQL syntax or updates existing ones. Make sure that:

  • Test cases about the new/updated syntax are added in src/sqlparser/tests/testdata. Especially, double check the formatted_sql is still a valid SQL #20713
  • The meaning of each enum variant is documented in PR description. Additionally, document what it means when each optional clause is omitted.

@github-actions github-actions bot added the type/feature Type: New feature. label Nov 11, 2025
@BugenZhao
Copy link
Member Author

BugenZhao commented Nov 12, 2025

This change is part of the following stack:

Change managed by git-spice.

@BugenZhao BugenZhao force-pushed the bz/parser-alter-config branch from 1331cad to 08f0882 Compare November 13, 2025 09:43
@BugenZhao BugenZhao requested review from hzxa21 and kwannoel November 14, 2025 04:33
@BugenZhao BugenZhao enabled auto-merge November 17, 2025 06:40
@BugenZhao BugenZhao added this pull request to the merge queue Nov 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 17, 2025
@BugenZhao BugenZhao added this pull request to the merge queue Nov 17, 2025
Merged via the queue into main with commit 6ec057b Nov 17, 2025
40 checks passed
@BugenZhao BugenZhao deleted the bz/parser-alter-config branch November 17, 2025 09:14
BugenZhao added a commit that referenced this pull request Nov 18, 2025
Standing-Man pushed a commit to Standing-Man/risingwave that referenced this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants