Skip to content

Conversation

@nWacky
Copy link

@nWacky nWacky commented Jul 29, 2022

  • Use image: ^3.2.0, flutter: ">=2.8.0"
  • Changed example to use flutter
  • Fixed out of bounds error with non square images

@risingwolf21
Copy link
Owner

Great work. Will merge when you finished that one comment.

@nWacky
Copy link
Author

nWacky commented Aug 16, 2022

Thank you.

Sorry, I cannot see any comments. Which one?

@risingwolf21
Copy link
Owner

In lib/edge_detection.dart line 47. Maybe we should use something like min(matrixXLen, matrixYLen) or we encounter the same out of bound error you mentioned. Am I right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants