Integrate Inja Code Generation #5
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add-data-binding: refactor: prefer camelCase chore: fix build warnings feat: add windows build scripts chore: bump rive runtime submodule chore: clang formatting feat: add data binding
…nV3.riv. The root cause was missing null pointer checks in three places: 1. Nested ViewModel Property Access (main.cpp:691-693) Problem: Chained calls viewModel->createInstance()->propertyViewModel() without null checks Fix: Added null checks for createInstance(), propertyViewModel(), instance(), and viewModel() 2. Enum Property Access (main.cpp:730-736) Problem: Chained calls accessing enum properties without null checks Fix: Added null checks for createViewModelInstance(), propertyValue(), and all subsequent property accesses 3. Default Value Property Access (main.cpp:786-818) Problem: Accessing property values without null checks for boolean, number, string, and color types Fix: Added null checks for each property value access 4. Nested Artboard Instance Access (main.cpp:525) Problem: nested->artboardInstance() could return null causing crash during recursion Fix: Added null check before recursively calling getNestedTextValueRunPathsFromArtboard() 5. Default Artboard Instance Access (main.cpp:882) Problem: defaultArtboard->instance()->defaultStateMachine() without null check on instance() Fix: Added null check for instance() before accessing defaultStateMachine()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mustache templating is very limiting in terms of logic and requires the data source to have a lot of granular information.
@inja is a modern c++ templating language that has a lot more control without requiring the data source to provide grandular details (eg. array size counts, whether a property exists, etc)
This adds an option to use Inja for code generation instead of Mustache to allow for more expressive templates that require complex logic for generating code.