Repository navigation
Conversation
bgentry
commented
Oct 22, 2026
bgentry
force-pushed
the
bg/split-rust-advisory-ci
branch
3 times, most recently
from
October 22, 2026 14:15
69b9a76 to
5bafc78
Compare
A newly disclosed dependency advisory can fail the combined Rust quality job even when a pull request changes no dependencies. Separate advisory scanning from lint, documentation, and dependency policy checks so each job reports its own result. Run security advisories in a `Rust advisories` job and keep license, ban, and source policies in `Rust quality`. Keep the existing workflow path filters so Rust checks run only for relevant changes.
bgentry
force-pushed
the
bg/split-rust-advisory-ci
branch
from
October 22, 2026 14:20
5bafc78 to
668bb8d
Compare
Contributor
Author
|
@brandur it seemed funky to me that Rust security advisories were bundled into the same CI check as things that should probably be blocking, like lint issues. This is my attempt to split them apart. Nothing is enforced as of now though—the way we have jobs/workflows only conditionally running on certain paths isn't really compatible with this, and we might want to rethink how that's done to be compatible with required checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate Rust security advisory scanning from the other quality checks. Today,
cargo denychecks advisories together with dependency licenses, bans, and sources, so a newly disclosed vulnerability can turn the quality job red even when a PR changes no dependencies.Rust qualitykeeps linting, documentation and examples, and dependency license, ban, and source checks. A separateRust advisoriesjob checks the security advisory database. Both jobs report their own results in the existing Rust workflow, keeping advisory failures visible without obscuring the quality checks we may want to require.Keep the existing workflow path filters so Rust checks continue to run only when Rust code or its shared inputs change.