Skip to content

Separate Rust advisory scanning from quality checks - #1526

Open
bgentry wants to merge 1 commit into
masterfrom
bg/split-rust-advisory-ci
Open

bgentry wants to merge 1 commit into
masterfrom
bg/split-rust-advisory-ci

Conversation

@bgentry

@bgentry bgentry commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Separate Rust security advisory scanning from the other quality checks. Today, cargo deny checks advisories together with dependency licenses, bans, and sources, so a newly disclosed vulnerability can turn the quality job red even when a PR changes no dependencies.

Rust quality keeps linting, documentation and examples, and dependency license, ban, and source checks. A separate Rust advisories job checks the security advisory database. Both jobs report their own results in the existing Rust workflow, keeping advisory failures visible without obscuring the quality checks we may want to require.

Keep the existing workflow path filters so Rust checks continue to run only when Rust code or its shared inputs change.

Comment thread .github/workflows/rust.yaml Outdated
@bgentry
bgentry force-pushed the bg/split-rust-advisory-ci branch 3 times, most recently from 69b9a76 to 5bafc78 Compare October 22, 2026 14:15
A newly disclosed dependency advisory can fail the combined Rust quality
job even when a pull request changes no dependencies. Separate advisory
scanning from lint, documentation, and dependency policy checks so each
job reports its own result.

Run security advisories in a `Rust advisories` job and keep license, ban,
and source policies in `Rust quality`. Keep the existing workflow path
filters so Rust checks run only for relevant changes.
@bgentry
bgentry force-pushed the bg/split-rust-advisory-ci branch from 5bafc78 to 668bb8d Compare October 22, 2026 14:20
@bgentry
bgentry requested a review from brandur October 22, 2026 14:27
@bgentry

bgentry commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

@brandur it seemed funky to me that Rust security advisories were bundled into the same CI check as things that should probably be blocking, like lint issues. This is my attempt to split them apart. Nothing is enforced as of now though—the way we have jobs/workflows only conditionally running on certain paths isn't really compatible with this, and we might want to rethink how that's done to be compatible with required checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant