Skip to content

fix: address PR #264 review issues#267

Open
NathanFlurry wants to merge 1 commit intomainfrom
desktop-viewer-refactor
Open

fix: address PR #264 review issues#267
NathanFlurry wants to merge 1 commit intomainfrom
desktop-viewer-refactor

Conversation

@NathanFlurry
Copy link
Member

Fix six issues found in the PR #264 desktop computer-use review:

  1. connectDesktopStream options: Forward RTCPeerConnection and rtcConfig options to DesktopStreamSession instead of silently dropping them.
  2. DesktopViewer reconnect loop: Store callback props in refs to prevent constant reconnect when using inline arrow functions.
  3. Recording race condition: Merge lock scopes in start() to fix TOCTOU race allowing duplicate concurrent recordings.
  4. Cursor bounds check: Add right/bottom edge checks to composite_cursor_region to prevent cursor drawn outside captured region.
  5. Missing documentation: Add DesktopViewer to react-components.mdx and document the new component with examples.
  6. Hardcoded styles: Remove all visual styles from DesktopViewer to make it unstyled by default per sdks/CLAUDE.md, export DesktopViewerClassNames for consumer styling.

🤖 Generated with Claude Code

- Fix connectDesktopStream silently dropping RTCPeerConnection and rtcConfig options (client.ts)
- Fix DesktopViewer useEffect dependency causing reconnect loop (store callbacks in refs)
- Fix TOCTOU race condition in DesktopRecordingManager::start() (merge lock scope)
- Fix incomplete cursor bounds check in composite_cursor_region (add right/bottom checks)
- Add DesktopViewer to react-components.mdx documentation
- Remove hardcoded visual styles from DesktopViewer (make unstyled by default per sdks/CLAUDE.md)
- Export DesktopViewerClassNames type for consumer styling

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@railway-app
Copy link

railway-app bot commented Mar 17, 2026

🚅 Deployed to the sandbox-agent-pr-267 environment in sandbox-agent

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Mar 17, 2026 at 9:57 am
foundry-api ❌ Build Failed (View Logs) Mar 17, 2026 at 9:50 am
foundry-mock ❌ Build Failed (View Logs) Mar 17, 2026 at 9:50 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant