Pihole.py fix for v0.6 #183
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p_address is not None. Please, feel forward to modify it in the correct way!
|
Hi, as a little information this PR will fix #180 I already tried the fix for the python version and the docker version and it works like a charm BR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am submitting only a fix of the pihole.py file inside the platform folder.
With the v0.6 update, pihole app was not showing the Stats on the dashboard.
It was throwing an error "Platform object has no attribute pihole"
I have added the initialization variables and checked that ip_address is != None.
Feel free to edit/remove anything.
Thanks for your work, DashMachine is awesome!