Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fixed names order according to data/testdata.json names order #168

Open
vnevgen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed names order according to data/testdata.json names order #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f123cb3
fixed names order according to data/testdata.json names order
vnevgen Nov 4, 2015
d5b7fed
placed note about alphabet order
vnevgen Nov 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ exports.asyncAnswers = {
},

manipulateRemoteData : function(url) {

// note that's important to output resulting names in alphabet order
}
};
2 changes: 1 addition & 1 deletion tests/app/async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('async behavior', function() {

asyncAnswers.manipulateRemoteData(url).then(function(result) {
expect(result).to.have.length(5);
expect(result.join(' ')).to.eql('Adam Alex Matt Paul Rebecca');
expect(result.join(' ')).to.eql('Matt Rebecca Paul Alex Adam');
Copy link
Owner

@rmurphey rmurphey Apr 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you've added the note in the code, this reordering isn't necessary.

done();
});
});
Expand Down