revert: serve lock RPC over goridge net/rpc, keep the new API - #91
Merged
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the lock service RPC transport from Connect-RPC back to net/rpc over the goridge codec while keeping the newer api-go message set and method names, and adjusts tests/dependencies accordingly.
Changes:
- Convert lock RPC handlers from Connect request/response types to
net/rpcstyle(in, out) error. - Update test RPC client helper to use
net/rpc+ goridge codec; remove Connect-only API tests and config. - Pin
api-go,goridge, andrpcdependencies to revert-branch pseudo-versions; remove Connect-related deps.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/rpc.go | Switch test client helper from Connect to net/rpc + goridge codec. |
| tests/lock_api_test.go | Remove Connect/HTTP/gRPC API surface tests tied to Connect handlers. |
| tests/go.mod | Drop Connect/grpc deps; add goridge + pin pseudo-versions for revert branches. |
| tests/go.sum | Remove Connect/grpc-related sums; add goridge + updated pseudo-version sums. |
| tests/configs/.rr-lock-api.yaml | Remove config used by the deleted Connect API tests. |
| rpc.go | Convert RPC methods from Connect handler signatures to net/rpc method signatures. |
| plugin.go | Expose RPC service object instead of an HTTP handler for Connect. |
| go.mod | Remove Connect requirement; pin api-go pseudo-version. |
| go.sum | Remove Connect-related sums; add updated api-go pseudo-version sums. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 79.37% 80.53% +1.16%
==========================================
Files 4 4
Lines 674 668 -6
==========================================
+ Hits 535 538 +3
+ Misses 119 111 -8
+ Partials 20 19 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the org-wide Connect-RPC revert: the RPC surface returns to net/rpc over the goridge codec while keeping the new api-go message set and method names. Connect handlers were converted in place, connect-only API tests removed, and api-go/goridge/rpc are pinned to the revert branches (pseudo-versions to be replaced by tags).