Replace WebKit with WebEngine #238
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Web https://doc.qt.io/qt-6/qtwebenginewidgets-qtwebkitportingguide.html was followed. 2. Only trivial modifications were done. More complex ones, such as those involving synchronous/asynchronous behaviours, functions which existed for QWebPage or QWebFrame but don't for QWebEnginePage, interactions with QNetworkAccessManager or running JavaScript for certan functions, only were changed very superficially. 3. As a consequence of 2., currently many code is probably not-working at all.
|
Thanks, just I'm not sure what to do with this PR 😀 |
I wrote some code in last year, too(didn't upload it), and I'd like to continue to contribute and help. May I ask that how is your progress besides this PR? |
Author
|
Thanks both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #236.
This is Work In Progress, as commented in the commit message. By the comment #236 (comment), maybe @boo-yee can take it.