Skip to content

Conversation

@aantn
Copy link
Collaborator

@aantn aantn commented Jan 18, 2026

Summary

  • remove Holmes workload health actions and related chat workflow
  • drop parameters and request types supporting workload health APIs
  • update default action list to exclude the removed workload health actions

Testing

  • Not run (not requested)

Codex Task

@github-actions
Copy link

github-actions bot commented Jan 18, 2026

Docker image ready for eb7d34c (built in 2m 36s)

⚠️ Warning: does not support ARM (ARM images are built on release only - not on every PR)

Use this tag to pull the image for testing.

📋 Copy commands

⚠️ Temporary images are deleted after 30 days. Copy to a permanent registry before using them:

gcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:eb7d34c
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:eb7d34c me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:eb7d34c
docker push me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:eb7d34c

Patch Helm values in one line:

helm upgrade --install robusta robusta/robusta \
  --reuse-values \
  --set runner.image=me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:eb7d34c

@coderabbitai
Copy link

coderabbitai bot commented Jan 18, 2026

Walkthrough

Holmes workload health-related features are removed from the system. This includes deletion of helm configuration entries, parameter classes (HolmesWorkloadHealthParams and HolmesWorkloadHealthChatParams), public playbook actions (holmes_workload_health, holmes_workload_chat, delayed_health_check), associated imports, and the HolmesWorkloadHealthRequest type definition.

Changes

Cohort / File(s) Change Summary
Helm Configuration
helm/robusta/values.yaml
Removed holmes_workload_health and holmes_workload_chat entries from lightActions configuration
Parameter Models
src/robusta/core/model/base_params.py
Removed class definitions HolmesWorkloadHealthParams(HolmesParams) and HolmesWorkloadHealthChatParams(HolmesParams) with their associated fields
Playbook Actions
src/robusta/core/playbooks/internal/ai_integration.py
Removed holmes_workload_health() and holmes_workload_chat() public functions; removed delayed_health_check() action and DelayedHealthCheckParams class; cleaned up imports (FixedDelayRepeat, KubernetesAnyChangeEvent, HolmesWorkloadHealthRequest)
Holmes Reporting
src/robusta/core/reporting/holmes.py
Removed HolmesWorkloadHealthRequest(HolmesChatRequest) class with workload_health_result and resource fields

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove Holmes workload health actions' clearly and specifically describes the main change in the changeset, which is the removal of Holmes workload health-related functions and actions.
Description check ✅ Passed The description is directly related to the changeset, providing clear details about the removal of Holmes workload health actions, parameters, request types, and the update to the default action list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/linear-mention-rob-115-check-if-there-is-any-reference-to

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants