Add hints for Num.to_str and Inspect.to_str does-not-exist errors - #10410
Open
JoeJoeflyn wants to merge 1 commit into
Open
Add hints for Num.to_str and Inspect.to_str does-not-exist errors#10410JoeJoeflyn wants to merge 1 commit into
JoeJoeflyn wants to merge 1 commit into
Conversation
When a Roc programmer uses the removed `Num.to_str` or renamed `Inspect.to_str`, the "Does Not Exist" error now shows a hint pointing to the replacement: - `Num.to_str(value)` -> use method syntax `value.to_str()` - `Inspect.to_str` -> renamed to `Str.inspect` Fixes roc-lang#9191 Fixes roc-lang#9192
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Num.to_str(value), the "Does Not Exist" error now hints to use method syntaxvalue.to_str()insteadInspect.to_str(value), the error now hints that it was renamed toStr.inspectModuleEnv.zig(e.g.addAnnotated("Hint:", .emphasized))Verification
zig build run-snapshot-tool -- test/snapshots/can_does_not_exist_inspect_to_str_hint.mdzig build run-check-snapshotszig build run-test-zig -- --test-filter "qualified_ident"— all 4 tests passedtest/snapshots/plume_package/Color.md(now shows the hint)Fixes #9191
Fixes #9192