Skip to content

Remove unused pydantic_numpy import from spectrum.py #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomdurrant merged 4 commits into from
Feb 24, 2026
Merged

Remove unused pydantic_numpy import from spectrum.py #26

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2aa24f3
Initial plan
Copilot Feb 19, 2026
3cecbd6
Remove unused pydantic_numpy import from spectrum.py
Copilot Feb 19, 2026
7433a3f
Replace numpy array types with list to avoid arbitrary types
Copilot Feb 19, 2026
49447f3
Improve type annotation to list[float] for better type safety
Copilot Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/rompy/core/spectrum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

import numpy as np
from pydantic import Field, model_validator
from pydantic_numpy.typing import Np1DArray

from rompy.core.types import RompyBaseModel

Expand All @@ -16,19 +15,19 @@ class Frequency(RompyBaseModel):
model_type: Literal["frequency", "FREQUENCY"] = Field(
default="frequency", description="Model type discriminator"
)
freq: Np1DArray = Field(description="Frequency array")
freq: list[float] = Field(description="Frequency array")

@property
def f0(self):
return self.freq.min()
return np.array(self.freq).min()

@property
def f1(self):
return self.freq.max()
return np.array(self.freq).max()

@property
def nf(self):
return self.freq.size
return len(self.freq)

@property
def flen(self):
Expand Down Expand Up @@ -109,7 +108,7 @@ def init_options(self) -> "LogFrequency":

return self

def __call__(self) -> Np1DArray:
def __call__(self):
"""Frequency array."""
return np.geomspace(self.f0, self.f1, self.nf)

Expand Down