[graf2d] Fix Setting window size in batch mode#21136
Open
rlalik wants to merge 1 commit intoroot-project:masterfrom
Open
[graf2d] Fix Setting window size in batch mode#21136rlalik wants to merge 1 commit intoroot-project:masterfrom
rlalik wants to merge 1 commit intoroot-project:masterfrom
Conversation
The current implementation doesn't make sense at all? Was it some accidentally commited code?
Member
|
No, this kind of calculation was there since a while. See: https://github.com/root-project/root/blob/v6-24-00-patches/graf2d/gpad/src/TCanvas.cxx#L2201 I only add special handling for web case |
Member
|
I have no idea why code looks like this but I prefer not to touch it. |
Contributor
Author
|
Well, in the batch mode there is indeed no window but this code changes the canvas size. And I would say, for compatibility reasons, should work properly. Otherwise macro run in batch mode will produce wrongly sized canvases. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation doesn't make sense at all? Was it some accidentally committed code?
@linev It was your commit? Was it mistake?