Move ROOT ML data loader to io #21137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vepadulano
requested review from
bellenot,
couet,
dpiparo,
guitargeek,
lmoneta and
pcanal
as code owners
vepadulano
force-pushed
the
dataloader-mv
branch
2 times, most recently
from
19bbbef to
d445f27
Compare
Test Results 22 files 22 suites 3d 12h 33m 0s ⏱️ For more details on these failures, see this check. Results for commit d445f27. |
pcanal
reviewed
Feb 4, 2026
The native ROOT data loading for ML training functionality is related to IO so it is moved to the io directory. In particular, a new subdirectory labeled 'ml' is created to host all the internal code relative to the functionality. The Python public API reflects the move by adopting a clearer naming, i.e. 'ROOT.IO.ML.*' for any class or function related to this feature. All public references to the name 'batch generator' are removed to avoid mixing responsibilities: RBatchGenerator is just the name of an internal class, which is never exposed to the user directly. Update tests and tutorials accordingly.
vepadulano
force-pushed
the
dataloader-mv
branch
from
d445f27 to
7827d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native ROOT data loading for ML training functionality is related to IO so
it is moved to the io directory. In particular, a new subdirectory labeled 'ml'
is created to host all the internal code relative to the functionality.
The Python public API reflects the move by adopting a clearer naming, i.e.
'ROOT.IO.ML.*' for any class or function related to this feature.
All public references to the name 'batch generator' are removed to avoid mixing
responsibilities: RBatchGenerator is just the name of an internal class, which
is never exposed to the user directly.
Update tests and tutorials accordingly.