Skip to content

[asimage] fix bug in rainbow palette selection #23725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linev merged 3 commits into from
Oct 19, 2026
Merged

[asimage] fix bug in rainbow palette selection #23725

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20f467a
[asimage] fix bug in rainbow palette selection
linev Oct 15, 2026
3427f9c
[asimage] provide size constant for rainbow palette
linev Oct 16, 2026
bc637f0
[asimage] use new constant in NewPalette
linev Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions graf2d/asimage/src/TASPaletteEditor.cxx
View file
Open in desktop
Comment thread
linev marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,17 @@ static const char *gFileTypes[] = {
nullptr, nullptr
};

static UShort_t gRedRainbow[12] = {
constexpr size_t kNRainbowElems = 10;

static UShort_t gRedRainbow[kNRainbowElems] = {
0x0000, 0x7000, 0x0000, 0x0000, 0x0000,
0xffff, 0xffff, 0x7000, 0x8000, 0xffff
};
static UShort_t gGreenRainbow[12] = {
static UShort_t gGreenRainbow[kNRainbowElems] = {
0x0000, 0x0000, 0x0000, 0xffff, 0xffff,
0xffff, 0x0000, 0x0000, 0x8000, 0xffff
};
static UShort_t gBlueRainbow[12] = {
static UShort_t gBlueRainbow[kNRainbowElems] = {
0x0000, 0x7000, 0xffff, 0xffff, 0x0000,
0x0000, 0x0000, 0x0000, 0xa000, 0xffff
};
Expand Down Expand Up @@ -672,13 +674,11 @@ void TASPaletteEditor::NewPalette(Long_t id)
if (id == 5) // empty entry
return;

TImagePalette *newPalette;

Double_t delta = fPalette->fPoints[fPalette->fNumPoints-2] - fPalette->fPoints[1];
UInt_t numPt;

numPt = id == 0 ? 12 : 13;
newPalette = new TImagePalette(numPt);
UInt_t numPt = id == 0 ? kNRainbowElems + 2 : 13;
TImagePalette *newPalette = new TImagePalette(numPt);

Int_t pt;
for (pt = 1; pt < Int_t(numPt - 1); pt++) {
newPalette->fPoints[pt] = fPalette->fPoints[1] + (pt - 1) * delta / (numPt - 3);
Expand All @@ -687,9 +687,9 @@ void TASPaletteEditor::NewPalette(Long_t id)

Comment thread
linev marked this conversation as resolved.
switch (id) {
case 0: // rainbow
memcpy(newPalette->fColorRed + 1, gRedRainbow, 12 * sizeof(UShort_t));
memcpy(newPalette->fColorGreen + 1, gGreenRainbow, 12 * sizeof(UShort_t));
memcpy(newPalette->fColorBlue + 1, gBlueRainbow, 12 * sizeof(UShort_t));
memcpy(newPalette->fColorRed + 1, gRedRainbow, kNRainbowElems * sizeof(UShort_t));
memcpy(newPalette->fColorGreen + 1, gGreenRainbow, kNRainbowElems * sizeof(UShort_t));
memcpy(newPalette->fColorBlue + 1, gBlueRainbow, kNRainbowElems * sizeof(UShort_t));
break;

case 1: // gray
Expand Down
Loading