Support WordPress 5.8 theme.json #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A first stab at supporting custom colours
Update sass-export so we don't try to force node-sass 5 which breaks new node.
…ut touching previous isNaN code
… mix with a public path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the code in PR #19 as it is dependant
I added a new configuration option to enable WordPress 5.8 theme.json support.
Hopefully the updated README explains everything pretty well, but essentially there is a new configuration option,
wp_theme_jsonwhich when enabled, will try and load theoutputoption, then append the palette in the right place (settings.color.palette).With this option, the user does not need to
add_theme_supportfor a palette, and all required classes for the block editor are compiled automatically (as detailed in https://make.wordpress.org/core/2021/06/25/introducing-theme-json-in-wordpress-5-8/)Edit: After submitting this PR, I realised that if the user isn't using mix with a
setPublicPath, forcing the output path to"../" + outputwould put the file in the wrong place, so I added another new propertyoutput_prependwhich just gets prepended tooutputto support writing theme.json outside of/publicfor those using mix/roots/sage, etc.