Skip to content

Conversation

@leander-dsouza
Copy link
Collaborator

@leander-dsouza leander-dsouza commented Oct 22, 2025

Basic Info

Info Please fill out this column
Ticket(s) this addresses N/A
Primary OS tested on Ubuntu
Is this a breaking change? No
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Expose testing of git, tar, and zip clients to be compatible with any external repo list file.

  • Added helper functions for these clients to create repositories/archives by locally cloning the repository, and checking them out to their target hashes before archiving.

  • Add the original list_repos.yaml back into testing, and modified the expected output to match the interaction with this file instead.

  • Use a remote clone as the codecov workflow sparsely checks out the branch under a single commit.

Description of how this change was tested

  • Performed linting validation using pre-commit run --all
  • Verified that the code passes all tests using python3 -m pytest -s -v test

@leander-dsouza leander-dsouza force-pushed the leander-dsouza/expose-yaml-testing branch 3 times, most recently from 59ad8cb to 3ee051d Compare October 23, 2025 00:59
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.98%. Comparing base (94538ef) to head (a2b9b3e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   26.98%   26.98%           
=======================================
  Files          31       31           
  Lines        2238     2238           
  Branches      392      392           
=======================================
  Hits          604      604           
  Misses       1574     1574           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leander-dsouza leander-dsouza marked this pull request as ready for review October 23, 2025 01:06
Copilot AI review requested due to automatic review settings October 23, 2025 01:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the test infrastructure to support testing git, tar, and zip clients using external repository files. Instead of creating synthetic test repositories and archives, the tests now use the original list_repos.yaml file which references the actual vcs2l repository on GitHub, with archives and repositories created by cloning and checking out specific commits.

Key changes:

  • Replaced synthetic test data generation with dynamic repository/archive creation based on external repos file
  • Added helper functions to create git repositories and tar/zip archives by cloning and checking out target commits
  • Updated all expected test outputs to reflect actual commit hashes and repository metadata from the external repository

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/init.py Added helper functions for repository/archive creation and modified StagedReposFile to use external repos file
test/test_commands.py Updated TestCommands to use LIST_REPOS_FILE and removed repos_file_url references
test/list_repos.yaml Added the original list.repos file with actual vcs2l repository references
test/*.txt Updated expected test outputs to reflect actual commit hashes and file paths from external repository
.github/workflows/ci.yml Added fetch-depth: 0 to checkout action for full git history

@leander-dsouza leander-dsouza force-pushed the leander-dsouza/expose-yaml-testing branch from 3ee051d to a6c5864 Compare October 23, 2025 01:26
@leander-dsouza leander-dsouza marked this pull request as draft October 23, 2025 01:27
@leander-dsouza leander-dsouza force-pushed the leander-dsouza/expose-yaml-testing branch from a6c5864 to fe267de Compare October 23, 2025 01:28
@leander-dsouza leander-dsouza force-pushed the leander-dsouza/expose-yaml-testing branch from fe267de to a2b9b3e Compare October 23, 2025 01:30
@leander-dsouza leander-dsouza marked this pull request as ready for review October 23, 2025 01:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants