fix package.xml deps#199
Open
jay-sridharan wants to merge 2 commits into
Open
Conversation
added 2 commits
May 28, 2026 00:38
Signed-off-by: Jay Sridharan <jsridharan@relativityspace.com>
| <exec_depend>builtin_interfaces</exec_depend> | ||
| <exec_depend>rosidl_default_runtime</exec_depend> | ||
| <exec_depend>python3-typing-extensions</exec_depend> | ||
| <exec_depend>unique_identifier_msgs</exec_depend> |
Collaborator
There was a problem hiding this comment.
AFAIS, it does not depend on unique_identifier_msgs anymore, can you explain why this is required to add here with microxrcedds failure?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds dependencies to package.xml that are required for message types that are pulled in from test_interface_files.
Not sure if this is the right place for this change - I know action_msgs and service_msgs are treated as special cases sometimes.
Is this user-facing behavior change?
Yes, fixes microxrcedds
Did you use Generative AI?
No
Additional Information
I was getting issues with some symbols from unique_identifier_msgs not being found because the build would sometimes happen out of order. Explicitly adding these dependencies fixes the issue.
Dependency Chain: