Skip to content

Add ament_mypy#1680

Open
InvincibleRMC wants to merge 4 commits into
rollingfrom
rmc/ament_mypy
Open

Add ament_mypy#1680
InvincibleRMC wants to merge 4 commits into
rollingfrom
rmc/ament_mypy

Conversation

@InvincibleRMC

@InvincibleRMC InvincibleRMC commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Description

Finally finish static typing of rclpy. Adds it under --ament-strict so no regressions can be introduced.

Fixes #1257

Is this user-facing behavior change?

This should help keep the typing api more stable.

Did you use Generative AI?

Additional Information

@InvincibleRMC
Add ament_mypy --ament-strict
b606d1e 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@mergify

mergify Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@InvincibleRMC

InvincibleRMC commented Jun 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Pulls: #1680
Gist: https://gist.githubusercontent.com/InvincibleRMC/d68ffc3446a514334025340bd6b4d7c6/raw/46f940b76fd3db5017a9f43bf6361d86e68cb8b2/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19616

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Build Status

@InvincibleRMC

InvincibleRMC commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

@mjcarroll I'm still fixing rhel but, the Windows failures I believe will go away after you merge ros2/ros2#1834

@InvincibleRMC
add type ignores for rhel
1d0a0cb 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC

InvincibleRMC commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

Pulls: #1680
Gist: https://gist.githubusercontent.com/InvincibleRMC/b4c05aefbfccf2262451225194f6d1f3/raw/46f940b76fd3db5017a9f43bf6361d86e68cb8b2/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19617

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
Fix flake8 bugs
b248abe 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC

InvincibleRMC commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

Pulls: #1680
Gist: https://gist.githubusercontent.com/InvincibleRMC/e940ad771dac56ecdefe685a88a469a3/raw/46f940b76fd3db5017a9f43bf6361d86e68cb8b2/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19619

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Jun 22, 2026
View reviewed changes

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, lgtm. just one minor comment.

Comment thread rclpy/rclpy/node.py Outdated
@InvincibleRMC
narrow types better
7e00aa4 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Static Type Checking With ament_mypy

2 participants

@InvincibleRMC @fujitatomoya