Add support for python 3.13 and 3.13t - #3
Merged
Conversation
yabirgb
commented
Jul 6, 2026
yabirgb
commented
Member
- syncs the code with python 3.13
- builds both 3.13 and 3.13t branches
yabirgb
force-pushed
the
python313
branch
2 times, most recently
from
July 7, 2026 06:45
bc94688 to
45dbc2f
Compare
Defining Py_BUILD_CORE globally makes Windows treat Python API data as core symbols instead of imported DLL symbols. The cp313t Windows wheel then fails to link references such as _Py_NoneStruct and PyExc_TypeError from objects that only use the public API.\n\nThe _sqlite sources that need CPython internals already define Py_BUILD_CORE_MODULE before including Python headers, which still enables internal headers while preserving dynamic module semantics on Windows.
kelsos
reviewed
Jul 7, 2026
Comment on lines
+171
to
+176
| $env:CIBW_BUILD = "cp313-*" | ||
| $env:LINK = "python313.lib" | ||
| python -m cibuildwheel --output-dir dist | ||
|
|
||
| $env:CIBW_BUILD = "cp313t-*" | ||
| $env:LINK = "python313t.lib" |
Member
There was a problem hiding this comment.
Is there any specific reason why we set the environment here
like this and we don't split it into two steps with their own env that each call their own cibuildwheel?
Also do they have to be separate can we have a single command build both?
Member
Author
There was a problem hiding this comment.
The reason it was there was because of a flag that I later removed and required to build against a specific DLL. I managed to remove the flag and now that specific dll is not needed for windows since the build can autodetect what is needed
kelsos
reviewed
Jul 7, 2026
kelsos
reviewed
Jul 7, 2026
kelsos
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.