util to convert the masks to bool + ruff bump#319
Open
TeunHuijben wants to merge 2 commits into
Open
Conversation
TeunHuijben
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest version of tracksdata stores masks as booleans in a GEFF. But previously exported GEFFs are saved as
uint64, which causes memory to explode upon loading.This PR implements a utility that converts the mask elements to booleans, either duplicating the geff or doing so in place.
Sorry for doing the
roughstuff as well in this PR, but GitHub CI takes the latest ruff, so I had to be compliant.