-
Notifications
You must be signed in to change notification settings - Fork 52
Use packit instead of rpm-gitoverlay to build nighly
#1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mfocko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| - component: libmodulemd | ||
| url: https://github.com/fedora-modularity/ | ||
| - component: libsolv | ||
| url: https://github.com/openSUSE/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed yesterday that we also have rpm-software-management/libsolv, given this I guess it's not used anymore? So should it be archived?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately there is a couple (one really) of small patches we need in RHEL that libsolv upstream doesn't want. Specifically its computing hashes using OpenSSL instead of the libsolv custom algorithms.
We store this in the rpm-software-management/libsolv.
Copr allows setting order of the builds, but IIRC |
eh… I guess there should be an option in the GitHub Action to propagate the build ID out… though I think it would need to be parsed from the Packit output; and now that I think about it, it would be sequential anyways 🤔 |
a9bff3c to
374bd82
Compare
Oh yea, right, I think that is what
We probably could build something to have it in batches but indeed I don't think it is worth it. We can always add it later if it turns out to cause problems. Perhaps even Packit will add some support (packit/packit-service#2105) that could be used in this use case. |
Since packit 1.6.0 `validate-config` was changed to `config validate`, new version of packit/pre-commit-hooks supports both. This started to happen now because since rpm-software-management/ci-dnf-stack#1771 packit is installed in `dnf-ci-host`. Previously without packit the `pre-commit - Validate package config` check was a no-op.
Since packit 1.6.0 `validate-config` was changed to `config validate`, new version of packit/pre-commit-hooks supports both. This started to happen now because since rpm-software-management/ci-dnf-stack#1771 packit is installed in `dnf-ci-host`. Previously without packit the `pre-commit - Validate package config` check was a no-op.
Since packit 1.6.0 `validate-config` was changed to `config validate`, new version of packit/pre-commit-hooks supports both. This started to happen now because since rpm-software-management#1771 packit is installed in `dnf-ci-host`. Previously without packit the `pre-commit - Validate package config` check was a no-op.
This requires: drpm, libcomps, dnf-plugins-core, dnf-plugins-extras, microdnf - to setup packit
It also requires dnf5 change to get the right version for all packit builds.
There is also a libsolv workaround because it is missing a packit setup as well but I think it is unlikely libsolv upstream would accept it.
Finally all the builds will run in parallel now so we loose the
requiresrelationship between components. This could cause problems when one package requires a new version of another. However I think the build should fail only once because in a second run the new dependency will be already built.One possible proper (and easy but slower) solution could be to configure the github action to do only one build at the time in the specified order.