Skip to content

Removed unnecessary workaround #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsbt merged 2 commits into from
Jun 4, 2025
Merged

Removed unnecessary workaround #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef93ba8
Use the latest version of assert_ractor for Ractor#value
hsbt Jun 4, 2025
86a7dac
Revert "Alias value to take in old Ruby"
hsbt Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ gem 'benchmark_driver'
gem 'memory_profiler'
gem 'jaro_winkler', '>= 1.4.0'
gem 'test-unit'
gem "test-unit-ruby-core"
gem "test-unit-ruby-core", ">= 1.0.7"

group :development do
gem "rake"
Expand Down
24 changes: 0 additions & 24 deletions test/test_ractor_compatibility.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
class RactorCompatibilityTest < Test::Unit::TestCase
def test_class_name_suggestion_works_in_ractor
assert_ractor(<<~CODE, require_relative: "helper")
class Ractor
alias value take
end unless Ractor.method_defined? :value # compat with Ruby 3.4 and olders

class ::Book; end
include DidYouMean::TestHelper
error = Ractor.new {
Expand All @@ -26,10 +22,6 @@ class ::Book; end

def test_key_name_suggestion_works_in_ractor
assert_ractor(<<~CODE, require_relative: "helper")
class Ractor
alias value take
end unless Ractor.method_defined? :value # compat with Ruby 3.4 and olders

include DidYouMean::TestHelper
error = Ractor.new {
begin
Expand All @@ -49,10 +41,6 @@ class Ractor

def test_method_name_suggestion_works_in_ractor
assert_ractor(<<~CODE, require_relative: "helper")
class Ractor
alias value take
end unless Ractor.method_defined? :value # compat with Ruby 3.4 and olders

include DidYouMean::TestHelper
error = Ractor.new {
begin
Expand All @@ -71,10 +59,6 @@ class Ractor
if defined?(::NoMatchingPatternKeyError)
def test_pattern_key_name_suggestion_works_in_ractor
assert_ractor(<<~CODE, require_relative: "helper")
class Ractor
alias value take
end unless Ractor.method_defined? :value # compat with Ruby 3.4 and olders

include DidYouMean::TestHelper
error = Ractor.new {
begin
Expand All @@ -97,10 +81,6 @@ class Ractor

def test_can_raise_other_name_error_in_ractor
assert_ractor(<<~CODE, require_relative: "helper")
class Ractor
alias value take
end unless Ractor.method_defined? :value # compat with Ruby 3.4 and olders

class FirstNameError < NameError; end
include DidYouMean::TestHelper
error = Ractor.new {
Expand All @@ -118,10 +98,6 @@ class FirstNameError < NameError; end

def test_variable_name_suggestion_works_in_ractor
assert_ractor(<<~CODE, require_relative: "helper")
class Ractor
alias value take
end unless Ractor.method_defined? :value # compat with Ruby 3.4 and olders

include DidYouMean::TestHelper
error = Ractor.new {
in_ractor = in_ractor = 1
Expand Down