Fix JSON.unsafe_load with proc argument#849
Merged
Merged
Conversation
…proc to JSON.unsafe_load, matching the changes made in 73d2137.
…rect use of proc argument.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 73d2137 (released with version 2.11.0) removes
JSON.recurse_procand its the call inJSON.load, opting instead to replace the call with the:on_loadoption. However, this is not the only instance ofrecurse_proc, and anyone usingJSON.unsafe_loadwith a proc will receive aNoMethodError.It would appear that
JSON.unsafe_loadhad no tests whatsoever, causing this failure.These commits:
JSON.unsafe_loadJSON.unsafe_loadwith the current behaviour ofJSON.load