Improve JSON.load and JSON.unsafe_load to allow passing options as second argument#910
Merged
Conversation
…s second argument Otherwise it's very error prone.
Member
|
If the options were keyword arguments that wouldn't need to be handled explicitly, but maybe that's not compatible enough if people pass a positional* Hash for options? |
Member
Author
Yeah, it's on my list of things to do. I want to migrate to keyword args, but quite unsure how much compatibility I'll break. I'll definitely do it for 3.0 if I can't find a deprecation path first though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise it's very error prone.
I'm experimenting with what
json3.0 will be like with thecreate_additionsremove, andJSON.loadno longer considered unsafe.This came up as a footgun.