Fix handling of depth#911
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few tests around the handling of depth when an exception (in particular
JSON::NestingError) is raised during JSON generation. The core idea is thatstate.depthshouldn't be changed when callingstate.generate(obj)orobj.to_json(state). While we can't be sure in the last case for user-controlled classes, we can reasonably ensure that it works withHashandArray.For CRuby, the approach is to never use the current State object, and always start generation with a
generate_json_data::vstateset toQfalse. It's only the first time we need to callto_json, that we create a temporary State which can be freely mutated by user code, since we never copy depth back from State togenerate_json_data. All subsequent calls toto_jsonwill use the same State, setting its depth to the correct value at that point.Since State is no longer mutated, we don't need
State#generate_newanymore.