Skip to content

Assert that objects are not T_NONE in the write barrier #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterzhu2118 merged 2 commits into from
Jan 9, 2026
Merged

Assert that objects are not T_NONE in the write barrier #63

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e34d5cf
Add MMTK_ASSERT
peterzhu2118 Jan 9, 2026
59d2720
Assert that objects are not T_NONE in the write barrier
peterzhu2118 Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions gc/mmtk/mmtk.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ RB_THREAD_LOCAL_SPECIFIER VALUE marking_parent_object;
# error We currently need language-supported TLS
#endif

#ifdef MMTK_DEBUG
# define MMTK_ASSERT(expr, ...) RUBY_ASSERT_ALWAYS(expr, #expr RBIMPL_VA_OPT_ARGS(__VA_ARGS__))
#else
# define MMTK_ASSERT(expr, ...) ((void)0)
#endif

#include <pthread.h>

static void
Expand Down Expand Up @@ -975,6 +981,9 @@ rb_gc_impl_writebarrier(void *objspace_ptr, VALUE a, VALUE b)
}
#endif

MMTK_ASSERT(BUILTIN_TYPE(a) != T_NONE);
MMTK_ASSERT(BUILTIN_TYPE(b) != T_NONE);

mmtk_object_reference_write_post(cache->mutator, (MMTk_ObjectReference)a);
}

Expand Down