Skip to content

Add JRuby's syslog - #28

Merged
hsbt merged 5 commits into
ruby:masterfrom
headius:jruby
Jan 9, 2026
Merged

hsbt merged 5 commits into
ruby:masterfrom
headius:jruby

Conversation

@headius

@headius headius commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

This syslog is defined using the FFI gem and JRuby's jnr-constants library for the syslog constants. The makefile is stubbed out on JRuby since it is not needed and the existing syslog.rb loads either the JRuby version or the standard C extension.

Fixes #1

@headius
headius marked this pull request as ready for review December 3, 2025 06:57
@headius
headius requested a review from knu as a code owner December 3, 2025 06:57
@headius

headius commented Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

Just in case...

@seydar I believe this is yours. Thank you! I would like to incorporate it into the official syslog gem, since JRuby depends on this version and the gem cannot otherwise be supported on JRuby.

Could you give your permission to relicense this code?

Just let us know that you consent to have your code released under the terms of the Ruby license and the 2-clause BSDL.

@headius

headius commented Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

Other than the licensing question, I believe this is ready to merge and release.

This was referenced Dec 3, 2025
Comment thread lib/syslog.rb Resolved
@headius

headius commented Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

I've sent a separate email to @seydar so hopefully we can get that licensing sorted out soon.

@seydar

seydar commented Dec 3, 2025

Copy link
Copy Markdown

You have my consent to relicense my syslog code.

I'm glad to see it get a second life! Thank you for your work in creating and pushing JRuby to be what it is — you are a load-bearing pillar of the Ruby community.

@headius

headius commented Dec 4, 2025

Copy link
Copy Markdown
Contributor Author

Looks like @knu and @hsbt are the core committers with the most contributions here...

@knu @hsbt As this is my first contribution to this gem, please review my change. It can be merged and released now, which will let us migrate JRuby to using the gem and fix #1 for our users.

This syslog is defined using the FFI gem and JRuby's jnr-constants
library for the syslog constants. The makefile is stubbed out on
JRuby since it is not needed and the existing syslog.rb loads
either the JRuby version or the standard C extension.

Fixes ruby#1
@headius

headius commented Dec 4, 2025

Copy link
Copy Markdown
Contributor Author

I have re-pushed with a final tweak and tested that the gem builds and works properly with my local JRuby.

@headius

headius commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

I've pushed a merge of the test.yml changes from master. Can this get merged and released soon?

@headius

headius commented Dec 31, 2025

Copy link
Copy Markdown
Contributor Author

We still have users waiting for this PR. What can I do to help get it merged and release? @hsbt @knu

@hsbt
hsbt merged commit 333018e into ruby:master Jan 9, 2026
42 checks passed
@headius
headius deleted the jruby branch January 9, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JRuby support

4 participants