Fix future_dates=ignore_entry scrub #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ignore_entry setting for the future_dates scrub incorrectly compared dates to time.time() (a float) rather than time.gmtime() (a time_struct).
openstack-gerrit
pushed a commit
to openstack/openstack-planet
that referenced
this pull request
Jan 18, 2016
If an entry arrives with a date in the future, disregard the date and use the internal fetch date instead. Note, the ignore_entry option is not safe to use without this patch: rubys/venus#35 Change-Id: If2c6ea31c8d60211e93615c6104d193e1970e271
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Jan 18, 2016
Project: openstack/openstack-planet 156b7996ec72cc532d68103b3c3b4bfb75a6c060 Ignore future dates If an entry arrives with a date in the future, disregard the date and use the internal fetch date instead. Note, the ignore_entry option is not safe to use without this patch: rubys/venus#35 Change-Id: If2c6ea31c8d60211e93615c6104d193e1970e271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ignore_entry setting for the future_dates scrub incorrectly compared dates
to time.time() (a float) rather than time.gmtime() (a time_struct).