Skip to content

fix: Use correct command name for ApprovePolicies #5934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lukemassa wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: Use correct command name for ApprovePolicies #5934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64e37f3
fix: Use correct command name
lukemassa Nov 4, 2025
abad196
Added some tests
lukemassa Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/events/project_command_runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ func (p *DefaultProjectCommandRunner) Apply(ctx command.ProjectContext) command.
func (p *DefaultProjectCommandRunner) ApprovePolicies(ctx command.ProjectContext) command.ProjectResult {
approvedOut, failure, err := p.doApprovePolicies(ctx)
return command.ProjectResult{
Command: command.PolicyCheck,
Command: command.ApprovePolicies,
Failure: failure,
Error: err,
PolicyCheckResults: approvedOut,
Expand Down
4 changes: 4 additions & 0 deletions server/events/project_command_runner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ func TestDefaultProjectCommandRunner_Plan(t *testing.T) {

Assert(t, res.PlanSuccess != nil, "exp plan success")
Equals(t, "https://lock-key", res.PlanSuccess.LockURL)
Equals(t, command.Plan, res.Command)
t.Logf("output is %s", res.PlanSuccess.TerraformOutput)
Equals(t, "run\napply\nplan\ninit", res.PlanSuccess.TerraformOutput)
expSteps := []string{"run", "apply", "plan", "init", "env"}
Expand Down Expand Up @@ -466,6 +467,7 @@ func TestDefaultProjectCommandRunner_Apply(t *testing.T) {
res := runner.Apply(ctx)
Equals(t, c.expOut, res.ApplySuccess)
Equals(t, c.expFailure, res.Failure)
Equals(t, command.Apply, res.Command)

for _, step := range c.expSteps {
switch step {
Expand Down Expand Up @@ -728,6 +730,7 @@ func TestDefaultProjectCommandRunner_Import(t *testing.T) {
res := runner.Import(ctx)
Equals(t, c.expOut, res.ImportSuccess)
Equals(t, c.expFailure, res.Failure)
Equals(t, command.Import, res.Command)

for _, step := range c.expSteps {
switch step {
Expand Down Expand Up @@ -1299,6 +1302,7 @@ func TestDefaultProjectCommandRunner_ApprovePolicies(t *testing.T) {
res := runner.ApprovePolicies(ctx)
Equals(t, c.expOut, res.PolicyCheckResults.PolicySetResults)
Equals(t, c.expFailure, res.Failure)
Equals(t, command.ApprovePolicies, res.Command)
if c.hasErr == true {
Assert(t, res.Error != nil, "expecting error.")
} else {
Expand Down